Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading XCode in CI to 13.0.0 #1612

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

vincentpierre
Copy link
Contributor

Motivation and Context

Xcode11.3.0 is to be deprecated. Attempting to upgrade to 13.0.0.

How Has This Been Tested

Running the CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 4, 2022
@Skylion007
Copy link
Contributor

This will bump our min osx version for Conda binaries FYI.

@erikwijmans
Copy link
Contributor

I don't think it will. IIRC clang's C++ libs on macOS are backward compatible as long as you aren't using features that don't exist in the old version.

@vincentpierre vincentpierre merged commit 97039d1 into facebookresearch:main Jan 5, 2022
@vincentpierre vincentpierre deleted the ci_xcode_upgrade branch January 5, 2022 19:02
@Skylion007
Copy link
Contributor

@vincentpierre Please ensure to squash the commits on the PR before merging. (You can do so through Github via the merge dropdown).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants