Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]--Cleaup;Remove unused field/methods. #1614

Merged
merged 4 commits into from
Jan 11, 2022

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Jan 5, 2022

Motivation and Context

In preparation for rewriting the asset load pipeline, I'm coming across some unused code in ResourceManager and the various mesh constructs, among other places. This PR is for removing these methods, so that the pending asset load functionality PRs will retain their focus :) . This PR also has a few minor refactors/cleanups that I've come across :

  • Remove unused/unimplemented voxel function declaration from Simulator.h
  • Make build script 'src_python' message a bit more relevant to the user
  • Remove deprecated config field from default physics config

How Has This Been Tested

All local c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 January 5, 2022 15:51
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 5, 2022
@Skylion007
Copy link
Contributor

@jturner65, feel free to use the codecov report to help find likely dead code.

@jturner65 jturner65 changed the title [WIP}[Refactor]--Remove unused field/methods relating to mesh handling. [WIP][Refactor]--Remove unused field/methods relating to mesh handling. Jan 5, 2022
@jturner65 jturner65 force-pushed the RM_Cleanup branch 2 times, most recently from 8563891 to 0386122 Compare January 11, 2022 15:20
@jturner65 jturner65 changed the title [WIP][Refactor]--Remove unused field/methods relating to mesh handling. [WIP][Refactor]--Cleaup;Remove unused field/methods. Jan 11, 2022
@jturner65 jturner65 marked this pull request as ready for review January 11, 2022 19:49
@jturner65 jturner65 changed the title [WIP][Refactor]--Cleaup;Remove unused field/methods. [Refactor]--Cleaup;Remove unused field/methods. Jan 11, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up. LGTM.

@jturner65 jturner65 merged commit da2ed89 into facebookresearch:main Jan 11, 2022
@jturner65 jturner65 deleted the RM_Cleanup branch January 11, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants