Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]--Support HM3D categories having commas between quotes #1652

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Feb 3, 2022

Motivation and Context

This bugfix addresses the rare case where HM3D annotation labels has commas embedded, so that they are loaded properly.

EDIT : unused includes were also removed.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 3, 2022
// (string), room/region ID (int)
// unique instance ID is first token
int instanceID = std::stoi(tokens[0]);
// Unique Instance ID (int), color (hex RGB), category name (may be multiple
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised the STL doesn't have a CSV parsers or something.

@jturner65 jturner65 merged commit d2c7503 into facebookresearch:main Feb 3, 2022
@jturner65 jturner65 deleted the HM3D_bugfix branch February 3, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants