Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gpu resource #1660

Merged
merged 4 commits into from
Feb 10, 2022
Merged

update gpu resource #1660

merged 4 commits into from
Feb 10, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 10, 2022

Motivation and Context

Update the GPU resource class to address CI resource deprecation.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 10, 2022
Copy link
Contributor

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work if you look closely at the log: Resource class gpu.nvidia.medium.multi for machine is not available for your project. This message will often appear if the pricing plan for this project does not support gpu.nvidia.medium.multi use. Default class medium will be used.

@aclegg3
Copy link
Contributor Author

aclegg3 commented Feb 10, 2022

This does not work if you look closely at the log: Resource class gpu.nvidia.medium.multi for machine is not available for your project. This message will often appear if the pricing plan for this project does not support gpu.nvidia.medium.multi use. Default class medium will be used.

I'm working with FB open source to address this.

Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@aclegg3 aclegg3 merged commit dc6374b into main Feb 10, 2022
@aclegg3 aclegg3 deleted the update-gpu-resource branch February 10, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants