Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky pytest-cov #1663

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Fix flaky pytest-cov #1663

merged 3 commits into from
Feb 14, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Noticed we still had pytest-cov pinned from when were still on 3.6. Now that we aren't, let's free up the requirement. I noticed it's been flaky lately. Hopefully this may fix it.

How Has This Been Tested

  • CI

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 14, 2022
jturner65
jturner65 approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Skylion007 Skylion007 merged commit 7452efd into main Feb 14, 2022
@Skylion007 Skylion007 deleted the fix-flakey-pytest-cov branch February 14, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot