Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]--fix replicaCAD quickstart to not default to showing the NONE scene #1682

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This addresses ReplicaCAD_quickstart.py only showing the NONE scene when run (the code would default to using the first scene in the list of available scenes, which would be the NONE scene since they are alphabetically sorted). Now the NONE scene is returned only if, for some reason, the list of scenes is empty. This is only an issue when running the code in python, since the drop-down scene select is not available there.

How Has This Been Tested

Locally tested both python and colab.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 3, 2022
@jturner65 jturner65 mentioned this pull request Mar 3, 2022
11 tasks
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvbatra
Copy link
Contributor

Yup, I get a video now. It looks like the agent was spawned below the stairs or in a corner because all I saw was gray, but a scene was loaded.

Let's land this and I can test again after rebasing.

@jturner65 jturner65 merged commit 085d5de into facebookresearch:main Mar 3, 2022
@jturner65 jturner65 deleted the ReplicaCAD_Bugfix branch March 3, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants