Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix osx conda nightly #1718

Merged
merged 1 commit into from
Apr 5, 2022
Merged

fix osx conda nightly #1718

merged 1 commit into from
Apr 5, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 5, 2022

Motivation and Context

The yes pipe working for linux is not working for osx as ci interprets the pipe return to terminate the job though it works in SSH.

How Has This Been Tested

Tested and working in CI on another branch.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 5, 2022
vincentpierre
vincentpierre approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@aclegg3 aclegg3 merged commit b2de13f into main Apr 5, 2022
@aclegg3 aclegg3 deleted the fix-nightly-osx-conda branch April 5, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aclegg3 @vincentpierre @facebook-github-bot