Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - compute navmesh visualization node AABB #1727

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 21, 2022

Motivation and Context

Set the SceneNode bounding box for navmesh visualization nodes upon creation. Fixes incorrect culling on navmesh visualization causing navmesh wireframes to disappear for some camera positions.

How Has This Been Tested

locally in viewer

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 April 21, 2022 00:02
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 21, 2022
@aclegg3 aclegg3 merged commit 30754f5 into main Apr 21, 2022
@aclegg3 aclegg3 deleted the navmesh-node-bb branch April 21, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants