Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update create_basis_compressed_glbs tool to use CgltfImporter #1730

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Apr 21, 2022

Motivation and Context

Updates the create_basis_compressed_glbs tool from TinyglTF to CgltfImporter

Also screens some false positives in finalize function where files in the working directory were getting picked up for rename and may not actually exist.

How Has This Been Tested

locally used the tool

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 21, 2022
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes can't wait to replace this tower of brittle scripts with a GltfSceneConverter and maybe just

magnum-sceneconverter file.gltf file.basisified.glb \
    -c imageConverter=BasisImageConverter,imageConverter/compression_level=X

Or a scripted version in a self-contained python script. Optimistically just a week away :)

@aclegg3 aclegg3 merged commit 8853e13 into main Apr 21, 2022
@aclegg3 aclegg3 deleted the create-basis-update branch April 21, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants