Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update Eigen to 3.4 #1746

Merged
merged 1 commit into from
May 5, 2022
Merged

deps: update Eigen to 3.4 #1746

merged 1 commit into from
May 5, 2022

Conversation

Skylion007
Copy link
Contributor

@Skylion007 Skylion007 commented May 5, 2022 •
edited

Motivation and Context

  • Updates Eigen to 3.4. Should give better performance, better static asserts, and is mostly a strict upgrade. Magnum and pybind11 are already tested with it so it feels like a good time to upgrade.
  • See http://eigen.tuxfamily.org/index.php?title=3.4 for full changelog

How Has This Been Tested

  • Locally

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 5, 2022
jturner65
jturner65 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it passes.

@Skylion007 Skylion007 merged commit ec81c8c into main May 5, 2022
@Skylion007 Skylion007 deleted the update-eigen-34 branch May 5, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot