Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] - viewer toggle lighting override with --stage-requires-lighting #1754

Merged
merged 1 commit into from
May 16, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 13, 2022

Motivation and Context

Override light setups with SimulatorConfiguration requires overrideSceneLightDefaults==true. Viewer --stage-requires-lighting argument should therefore set both overrideSceneLightDefaults and sceneLightSetupKey to function.

How Has This Been Tested

locally w/ viewer and test assets.
./build/viewer --recompute-navmesh --stage-requires-lighting -- data/test_assets/scenes/simple_room.glb

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 May 13, 2022 21:24
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 13, 2022
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aclegg3 aclegg3 merged commit 87c498f into main May 16, 2022
@aclegg3 aclegg3 deleted the viewer-fix branch May 16, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants