Gfx-replay and JSON serialization fixes #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
eundersander
commented
May 18, 2022
| addMember(obj, "shaderTypeToUse", x.shaderTypeToUse, allocator); | ||
| addMember(obj, "overridePhongMaterial", x.overridePhongMaterial, allocator); | ||
| addMember(obj, "hasSemanticTextures", x.hasSemanticTextures, allocator); | ||
| JsonGenericValue toJsonValue(const esp::assets::AssetInfo& x, |
There was a problem hiding this comment.
moving these implementations to the cpp to avoid compile errors
jturner65
approved these changes
May 18, 2022
Skylion007
approved these changes
May 18, 2022
Closed
7 tasks
eundersander
force-pushed
the
eundersander/gfx_replay_fixes
branch
from
e3e9de7
to
cbec4b9
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A few related fixes. Motivation: Gfx-replay will be used soon for Blender import as well as batch rendering.
How Has This Been Tested
Types of changes
Checklist