[WIP][bugfix] - Working with Lights tutorial update #1760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As acknowledged in several issues (e.g. #1450), the lighting tutorial
Working with Lights
is a bit out of date.The goal of this PR is to apply necessary changes to fix and update the tutorial.
Changes:
SimulatorConfiguration.override_scene_light_defaults
must be set toTrue
directional == [x,y,z,0]
,point == [x,y,z,1]
)TODO:
How Has This Been Tested
On CI and locally.
Types of changes
Checklist