Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][bugfix] - Working with Lights tutorial update #1760

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 18, 2022

Motivation and Context

As acknowledged in several issues (e.g. #1450), the lighting tutorial Working with Lights is a bit out of date.
The goal of this PR is to apply necessary changes to fix and update the tutorial.

Changes:

  • To change the Stage lighting, SimulatorConfiguration.override_scene_light_defaults must be set to True
  • Specify point vs. directional lights with homogenous 4th vector value (directional == [x,y,z,0], point == [x,y,z,1])

TODO:

  • update the example settings to better values given new lighting schemes.

How Has This Been Tested

On CI and locally.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 May 18, 2022 22:55
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 18, 2022
@aclegg3 aclegg3 marked this pull request as ready for review June 8, 2022 21:19
@aclegg3 aclegg3 merged commit 99eab33 into main Jun 8, 2022
@aclegg3 aclegg3 deleted the lighting-tutorial-update branch June 8, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants