Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robots in hablab #1790

Merged
merged 5 commits into from
Jul 6, 2022
Merged

Robots in hablab #1790

merged 5 commits into from
Jul 6, 2022

Conversation

zachavis
Copy link
Contributor

Motivation and Context

This PR removes robot scripts (Fetch) and test cases from habitat-sim, since they were migrated to habitat-lab (#888). This helps to decouple habitat-sim from the definition of a robot, allowing users to use higher level wrappers like habitat-lab to more easily handle configuring embodied agents.

How Has This Been Tested

The robot scripts were removed from habitat-sim and into a local copy of habitat-lab; In habitat-lab, examples/interactive_play.py script ran with Fetch loaded and no issues, and pytest test/test_robot_wrapper.py ran with both tests passing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zachavis zachavis requested a review from aclegg3 June 20, 2022 17:09
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 20, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for refactoring this.

@aclegg3 aclegg3 merged commit 69792b1 into facebookresearch:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants