Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(bugfix): Prevent unnecessary copies with more std::move and emplace #1870

Merged
merged 6 commits into from
Sep 22, 2022
Merged

(bugfix): Prevent unnecessary copies with more std::move and emplace #1870

merged 6 commits into from
Sep 22, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • When I was reviewing @jturner65's PR, I noticed a series of strings that were being copied into their std::set. This explicitly moves them when inserting them into the set instead which should prevent an unnecessary copy.

How Has This Been Tested

Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 22, 2022
@Skylion007 Skylion007 changed the title (bugfix): Prevent unnecessary copies of tmp handles in metadata manager (bugfix): Prevent unnecessary copies with more std::move and emplace Sep 22, 2022
jturner65
jturner65 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Skylion007 Skylion007 merged commit 45c90b9 into main Sep 22, 2022
@Skylion007 Skylion007 deleted the mmgrs-tmplt-handle-insert-move branch September 22, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

@jrreyna jrreyna Awaiting requested review from jrreyna

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Skylion007 @jturner65 @facebook-github-bot