Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Updated Fetch Model #1959

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Added Updated Fetch Model #1959

merged 3 commits into from
Dec 5, 2022

Conversation

ASzot
Copy link
Contributor

@ASzot ASzot commented Dec 4, 2022

Motivation and Context

The v1 Fetch Suction robot gripper URDF model had the issue where some of the links would create strange ghost forces that were very large (>1 million Newtons in a single time step). This change adds the download to get the fixed Fetch model that no longer has this issue.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 4, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lab tests are failing. Is there a lab incompatibility with asset naming in a config or something?

@aclegg3 aclegg3 merged commit 5269d82 into main Dec 5, 2022
@aclegg3 aclegg3 deleted the new_fetch_suction branch December 5, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants