Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update magnum-bindings for MeshData fix on py3.7 #2003

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Update magnum-bindings for MeshData fix on py3.7 #2003

merged 1 commit into from
Feb 10, 2023

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Feb 10, 2023

Motivation and Context

Pulling small fix in magnum-bindings to handle python 3.7 error with pybind11 overload ordering. Supports Habitat-lab 1108.
See mosra/magnum-bindings@b3e24a1 for details.

How Has This Been Tested

Locally + CI passes

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 10, 2023
mosra
mosra approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@mosra mosra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles, it's correct :D

@aclegg3 aclegg3 merged commit dd1b1ff into main Feb 10, 2023
@aclegg3 aclegg3 deleted the update-magnum-bindings branch February 10, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosra mosra mosra approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@eundersander eundersander Awaiting requested review from eundersander

@0mdc 0mdc Awaiting requested review from 0mdc

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aclegg3 @mosra @Skylion007 @facebook-github-bot