[CI Fix] Fix flake8 errors. #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Sorry, that my commit to flake8-comprehensions. Meant to go and ruff on habitat-lab as well. |
Skylion007
reviewed
Mar 20, 2023
| @@ -38,7 +38,6 @@ def test_semantic_scene(scene, make_cfg_settings): | |||
| if not osp.exists(scene): | |||
| pytest.skip("Skipping {}".format(scene)) | |||
|
|
|||
| make_cfg_settings = {k: v for k, v in make_cfg_settings.items()} | |||
There was a problem hiding this comment.
Is this suppose to be a copy()?
There was a problem hiding this comment.
The make_cfg_settings passed to the test is already a copy.
Line 25 in fed4be9
def make_cfg_settings():
import habitat_sim.utils.settings
cfg = habitat_sim.utils.settings.default_sim_settings.copy()
{...}
return cfg
Skylion007
reviewed
Mar 20, 2023
| @@ -276,7 +276,6 @@ def test_smoke_no_sensors(make_cfg_settings): | |||
| if not osp.exists(scene): | |||
| continue | |||
| scene_dataset_config = scene_and_dataset[1] | |||
| make_cfg_settings = {k: v for k, v in make_cfg_settings.items()} | |||
Skylion007
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes two flake8 errors that surfaced after a dependency upgrade.
How Has This Been Tested
Tested on CI.
Types of changes
Checklist