Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--[BE Week]Minor Lighting-related refactoring #2148

Merged
merged 2 commits into from
Jul 5, 2023
Merged

--[BE Week]Minor Lighting-related refactoring #2148

merged 2 commits into from
Jul 5, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR addresses a few minor issues.

  • The viewer.py/viewer.cpp tag "--stage-requires-lighting" is renamed to the more accurate "--use-default-lighting"
  • Our internally-specified lighting keys "NO_LIGHT_KEY" and "DEFAULT_LIGHTING_KEY" are handled more appropriately when a light setup is requested by name from the LightLayoutAttributesManager.

How Has This Been Tested

C++ and Python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 5, 2023
@jturner65 jturner65 requested review from eundersander and removed request for Skylion007 July 5, 2023 16:02
0mdc
0mdc approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65 jturner65 merged commit 3a7cc3a into main Jul 5, 2023
10 checks passed
@jturner65 jturner65 deleted the BE_LightingRefactors branch July 5, 2023 19:59
@jturner65 jturner65 mentioned this pull request Jul 11, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jturner65 @0mdc @facebook-github-bot