Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes to add image extractor tutorial to website #535

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Small changes to add image extractor tutorial to website #535

merged 3 commits into from
Mar 20, 2020

Conversation

mpiseno
Copy link

@mpiseno mpiseno commented Mar 18, 2020

Motivation and Context

Making links work on the website

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@mpiseno mpiseno requested a review from mathfac March 18, 2020 23:34
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 18, 2020
@mpiseno
Copy link
Author

mpiseno commented Mar 18, 2020

@mathfac Not sure how to test if this is correct, but let me know if there's anything else I need to change!

@codecov
Copy link

codecov bot commented Mar 19, 2020 •
edited
Loading

Codecov Report

Merging #535 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   62.04%   62.04%           
=======================================
  Files         167      167           
  Lines        7836     7836           
  Branches       84       84           
=======================================
  Hits         4862     4862           
  Misses       2974     2974
Flag Coverage Δ
#CPP 57.45% <ø> (ø)
#JavaScript 10.00% <ø> (ø)
#Python 80.31% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ad27bf...2aaf168. Read the comment docs.

mathfac
mathfac approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test the doc change end-to-end requires non trivial setup. As Build documentation step in CI is passing it should be great to go.

@mathfac mathfac merged commit ceed9d9 into master Mar 20, 2020
@mathfac mathfac deleted the tutorial-changes branch March 20, 2020 16:07
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
Small changes to add image extractor tutorial to website (facebookres…
baca6f4 
…earch#535)

Making links work on the website
luoj1 pushed a commit to luoj1/habitat-sim that referenced this pull request Aug 16, 2022
@Skylion007
Fix more incorrect typehints in Habitat Core (facebookresearch#535)
b7a93bc 
* Try to enable typeguard and more typing fixes

* Fix more typing issues

* Fix flake8 errors

* Fix VisualObservations

* Add habitat_sim to mypy.ini

* Redisable typeguard

* Make Torch soft dependency again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathfac mathfac mathfac approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpiseno @mathfac @facebook-github-bot