Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of adding additional actions #56

Merged
merged 13 commits into from
Jun 4, 2019
Merged

Example of adding additional actions #56

merged 13 commits into from
Jun 4, 2019

Conversation

erikwijmans
Copy link
Contributor

Motivation and Context

We need more examples!

This example shows how introduce new control functions, register them, and then use them as actions for the agent!

How Has This Been Tested

Ran the script and states look correct. Would dumping images be useful?

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 28, 2019
Copy link
Collaborator

@msavva msavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @erikwijmans -- will help folks get a much better sense of the flexibility available in defining custom actions. LGTM 👍

examples/new_actions.py Outdated Show resolved Hide resolved
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank for adding this. Now it's easier to understand/show variety of things we can do with an action space in the simulator.

@erikwijmans
Copy link
Contributor Author

Landing.

@erikwijmans erikwijmans merged commit ab19891 into master Jun 4, 2019
@erikwijmans erikwijmans deleted the hsim-examples branch June 4, 2019 18:54
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* Example for creating new actions

* Just print

* Strafing

* Better comment

* Kill print

* Better job taking axis

* Move things

* Revamp example and add test to example

* Add a little more

* Slight fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants