Example of creating a stereo agent #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
msavva
approved these changes
May 31, 2019
There was a problem hiding this comment.
This is awesome -- thanks @erikwijmans . Left a few comments on typos. Also, color frames look like they have BGR vs RGB color channel flip (likely cv2 expects the former channel order by default). Other than these small fixes, LGTM! 👍
I am so bad at remembering to do that..... |
… stereo-agent-example
… stereo-agent-example
mathfac
approved these changes
Jun 4, 2019
|
@erikwijmans since this PR has now been reviewed, shall we land it for release? |
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* Stereo agent example * Add test * Add some comments * Render at 256 * Smoke test more * Mark as gfx * Typos, BGR vs RGB, and get ready for multiple examples to test! * Little change * Rename * Nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See #56 for context!
This one adds an example of creating an agent that uses a stereo RGB pair or a stereo depth pair. The displaying to the user is done via cv2
How Has This Been Tested
Also via the new smoke test in pytest.
Types of changes