Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting to CI #67

Merged
merged 16 commits into from
Jun 12, 2019
Merged

Add linting to CI #67

merged 16 commits into from
Jun 12, 2019

Conversation

erikwijmans
Copy link
Contributor

Motivation and Context

Add linting to CI

How Has This Been Tested

With the CI!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 5, 2019
@erikwijmans
Copy link
Contributor Author

There is one caveat with this: clang-format-8 (which is what is on MacOS) gives different results on clang-format-7 (which is the most recent version available on common ubuntu version), so it is kinda annoying to get formatting correct on linux.

@erikwijmans
Copy link
Contributor Author

Although clang-format-8 is available on linuxbrew and via conda install clangdev -c conda-forge so simple enough.

@erikwijmans
Copy link
Contributor Author

@mathfac @msavva does this make sense to add?

msavva
msavva approved these changes Jun 12, 2019
View reviewed changes
Copy link
Collaborator

@msavva msavva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely. Looks good to me @erikwijmans ! 👍

mathfac
mathfac approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, definitely useful.

@mathfac mathfac merged commit 1fdd7b0 into master Jun 12, 2019
@mathfac mathfac deleted the add-linting-ci branch June 12, 2019 20:14
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@erikwijmans @mathfac
Add linting to CI (facebookresearch#67)
43ba7ab 
* Add linting to CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msavva msavva msavva approved these changes

@mathfac mathfac mathfac approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@erikwijmans @msavva @mathfac @facebook-github-bot