-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive Defaults List support #1044
Conversation
8c04575
to
0987064
Compare
0987064
to
f51ab94
Compare
This pull request introduces 1 alert when merging 01379f3 into 6374fa2 - view on LGTM.com new alerts:
|
01379f3
to
5a1f9f2
Compare
This pull request introduces 1 alert when merging 5a1f9f2 into 1503d1d - view on LGTM.com new alerts:
|
03fd961
to
d5b494a
Compare
This pull request introduces 1 alert when merging d5b494a into 8adcee0 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 878a458 into 8adcee0 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a708283 into 3775a29 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging dd5caaa into 3775a29 - view on LGTM.com new alerts:
|
dd5caaa
to
4e3cf74
Compare
1ea3521
to
992416d
Compare
195522e
to
7a0746b
Compare
Core tests are passing
7a0746b
to
1b76c09
Compare
Does this mean that the new style will also support nested variables for specialization? Or rather would the following work if I were to extend your last example?
This would be an extremely useful pattern, I am currently lacking this feature in an existing project, but just wanted to confirm before submitting a feature request. |
No. the defaults list will never be able to use config variables in interpolation. |
FYI: #1170 re-implements this and will be merged soon. |
(when the version_base is >= 1.2). The old ${defaults.N.name} format was deprecated, and slated for removal in 1.2. Follows on from the support of the newer format in PR facebookresearch#1044 Addresses issue facebookresearch#1891
Closes #171
Closes #326
Closes #1080
Closes #1089
_self_
support (Ability to specify composition order of primary config file #326)- group: null
deletion form from defaults list in favor of~group
and~group=value
._self_
to be last in the list and not first as it is now_self_
This:
Will become: