Skip to content
This repository has been archived by the owner on Nov 1, 2024. It is now read-only.

Add MyPy to CI #103

Merged
merged 5 commits into from
May 17, 2022
Merged

Add MyPy to CI #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
666178d
add mypy as a dependency
TommyDew42 May 17, 2022
0cd4dbb
add mypy.ini
TommyDew42 May 17, 2022
b8ea7cc
add mypy ci
TommyDew42 May 17, 2022
062397b
allow mypy ci error to exit sucessfully
TommyDew42 May 17, 2022
54e5617
change python version to 3.8 in mypy.ini
TommyDew42 May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,8 @@ jobs:
run: |
pip install black
black --check .

- name: Type Checking with MyPy
run: |
pip install mypy
mypy || true
5 changes: 5 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[mypy]
python_version = 3.8
ignore_missing_imports = true
files = metaseq,metaseq_cli,tests,cpu_tests,gpu_tests
pretty = false
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ def do_setup(package_data):
"Jinja2==3.1.1", # for evals
"markupsafe", # for evals
"more_itertools",
"mypy",
"ninja",
'numpy; python_version>="3.7"',
"omegaconf",
Expand Down