Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tactile pushing model interface #55

Merged
merged 8 commits into from
Feb 2, 2022
Merged

Refactor tactile pushing model interface #55

merged 8 commits into from
Feb 2, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 31, 2022

Motivation and Context

Continuation of #51 and #52

How Has This Been Tested

See #51

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luisenp luisenp added experiments Experiments using latest features refactor Refactor library components labels Jan 31, 2022
@luisenp luisenp self-assigned this Jan 31, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2022
@luisenp luisenp force-pushed the lep.refactor_tactile_pushing_model branch from 601da7b to b37fda5 Compare January 31, 2022 14:08
mhmukadam
mhmukadam approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Would be useful to test (if not already) a scenario where the training is cut off and resumed from a checkpoint, and a scenario where inference is performed by loading a model that is trained and saved from before.

@luisenp luisenp mentioned this pull request Feb 1, 2022
Open
@luisenp luisenp changed the base branch from main to lep.minor_fixes_20220201 February 2, 2022 19:52
@luisenp luisenp changed the base branch from lep.minor_fixes_20220201 to main February 2, 2022 19:52
@luisenp luisenp merged commit 06699cc into main Feb 2, 2022
@luisenp luisenp deleted the lep.refactor_tactile_pushing_model branch February 2, 2022 19:57
ddetone pushed a commit that referenced this pull request Mar 29, 2022
@mhmukadam
Merge pull request #55 from fairinternal/sparse_end_to_end_test
20112e6 
Sparse end to end test
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Refactor tactile pushing model interface (facebookresearch#55)
6b060b3 
* Added utility for creating all tactile pushing models according to a given config.

* Added utility for updating all theseus inputs in tactile pushing.

* Refactored method to convert extract tactile pose tensors from theseus output dict.

* Small clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. experiments Experiments using latest features refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@luisenp @mhmukadam @facebook-github-bot