Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a TactilePoseEstimator class to easily create TheseusLayer for tactile pushing #52

Merged
merged 4 commits into from
Feb 2, 2022
Merged

Added a TactilePoseEstimator class to easily create TheseusLayer for tactile pushing #52

merged 4 commits into from
Feb 2, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 28, 2022

Motivation and Context

See #51

How Has This Been Tested

As in #51

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luisenp luisenp added experiments Experiments using latest features refactor Refactor library components labels Jan 28, 2022
@luisenp luisenp self-assigned this Jan 28, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2022
@luisenp luisenp changed the title Create TactilePoseEstimator to easily create TheseusLayer for tactile pushing Added a TactilePoseEstimator class to easily create TheseusLayer for tactile pushing Jan 28, 2022
@luisenp luisenp mentioned this pull request Jan 31, 2022
Merged
11 tasks
mhmukadam
mhmukadam approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There seems to be come conflict in a file but good to merge otherwise. (Also the dataset class stuff reappears here from the previous PR)

@luisenp luisenp merged commit 310ffcf into main Feb 2, 2022
@luisenp luisenp deleted the lep.refactor_tactile_pushing_ex branch February 2, 2022 19:49
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Added a TactilePoseEstimator class to easily create TheseusLayer for …
88fccaf 
…tactile pushing (facebookresearch#52)

* [refactor] Created TactilePoseEstimator class to easily construct the TheseusLayer for tactile pushing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. experiments Experiments using latest features refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisenp @mhmukadam @facebook-github-bot