Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulated data loading functions in tactile pushing example into a new class #51

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Encapsulated data loading functions in tactile pushing example into a new class #51

merged 2 commits into from
Feb 2, 2022

Conversation

luisenp
Copy link
Contributor

@luisenp luisenp commented Jan 28, 2022

Motivation and Context

This is one of several coming PRs In preparation for the backward pass experiments. I'm cleaning up the tactile pushing example to make it easier to run the resulting optimization problems in scripts outside of the examples folder.

How Has This Been Tested

Ran 1 epoch of the example and the results match the original.

image

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luisenp luisenp added experiments Experiments using latest features refactor Refactor library components labels Jan 28, 2022
@luisenp luisenp self-assigned this Jan 28, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2022
This was referenced Jan 28, 2022
Merged
Merged
mhmukadam
mhmukadam approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@mhmukadam mhmukadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nicely streamlined data loading!

@luisenp luisenp merged commit 17a4171 into main Feb 2, 2022
@luisenp luisenp deleted the lep.refactor_tactile_pushing_dataset branch February 2, 2022 19:30
ddetone pushed a commit that referenced this pull request Mar 29, 2022
@mhmukadam
Merge pull request #51 from fairinternal/lep.collision_factor
7f5ce3c 
Implemented a collision factor for 2D geometry
suddhu pushed a commit to suddhu/theseus that referenced this pull request Jan 21, 2023
@luisenp
Encapsulated data loading functions in tactile pushing example into a…
730e0cb 
… new class (facebookresearch#51)

* [refactor] Encapsulated data loading functions in tactile pushing example in a new class.

* Added function to get measurements batches from tactile pushing dataset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psodhi psodhi psodhi left review comments

@mhmukadam mhmukadam mhmukadam approved these changes

Assignees

@luisenp luisenp

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. experiments Experiments using latest features refactor Refactor library components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisenp @mhmukadam @psodhi @facebook-github-bot