Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split xformers.ops #486

Merged
merged 5 commits into from
Nov 10, 2022
Merged

Split xformers.ops #486

merged 5 commits into from
Nov 10, 2022

Conversation

[ghstack-poisoned]
danthe3rd pushed a commit that referenced this pull request Oct 20, 2022
ghstack-source-id: ed57e2fe82d9a6875b91022fabaae4de89757913
Pull Request resolved: #486
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2022
@danthe3rd danthe3rd requested a review from fmassa October 20, 2022 13:06
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Daniel!

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Base: 90.56% // Head: 90.56% // No change to project coverage 👍

Coverage data is based on head (8407de3) compared to base (8407de3).
Patch has no changes to coverable lines.

❗ Current head 8407de3 differs from pull request most recent head 9a0d544. Consider uploading reports for the commit 9a0d544 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           gh/danthe3rd/49/base     #486   +/-   ##
=====================================================
  Coverage                 90.56%   90.56%           
=====================================================
  Files                        76       76           
  Lines                      4580     4580           
=====================================================
  Hits                       4148     4148           
  Misses                      432      432           
Flag Coverage Δ
Python 90.56% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

**SUMMARY**
As discussed offline with fmassa , will make extending new operators clearner

[ghstack-poisoned]
**SUMMARY**
As discussed offline with fmassa , will make extending new operators clearner

[ghstack-poisoned]
**SUMMARY**
As discussed offline with fmassa , will make extending new operators clearner

[ghstack-poisoned]
**SUMMARY**
As discussed offline with fmassa , will make extending new operators clearner

[ghstack-poisoned]
@danthe3rd danthe3rd merged commit 9a0d544 into gh/danthe3rd/49/base Nov 10, 2022
danthe3rd pushed a commit that referenced this pull request Nov 10, 2022
ghstack-source-id: c1d0cff8181eb95273aa00b69d1d60fb7193b54a
Pull Request resolved: #486
@danthe3rd danthe3rd deleted the gh/danthe3rd/49/head branch November 10, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants