Should fix OOMs in CI #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 21, 2022
Merged
facebook-github-bot
added
the
CLA Signed
danthe3rd
pushed a commit
that referenced
this pull request
Oct 21, 2022
ghstack-source-id: 5c63e28806a736bd26d9dc218d84fe860bd88802 Pull Request resolved: #488
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 21, 2022
ghstack-source-id: 0e543590f9fca47bd4ff1ab81dc60a37292d28c6 Pull Request resolved: #488
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Oct 21, 2022
ghstack-source-id: c57a2695e7870461157302777bc90e14cfc00f33 Pull Request resolved: #488
Codecov ReportBase: 90.57% // Head: 90.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## gh/danthe3rd/51/base #488 +/- ##
=====================================================
Coverage 90.57% 90.58%
=====================================================
Files 79 79
Lines 4649 4650 +1
=====================================================
+ Hits 4211 4212 +1
Misses 438 438
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This was referenced Oct 24, 2022
Merged
Merged
[ghstack-poisoned]
This was referenced Oct 28, 2022
added 4 commits
October 28, 2022 16:00
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
fmassa
approved these changes
Nov 2, 2022
| @@ -91,7 +91,7 @@ install_dep: &install_dep | |||
| conda install ninja | |||
| echo "Ninja version $(ninja --version)" | |||
|
|
|||
| conda install pytorch "torchvision>=0.13" torchaudio cudatoolkit=11.3 -c pytorch -q | |||
| conda install pytorch=1.12.1 "torchvision>=0.13" torchaudio cudatoolkit=11.3 -c pytorch -q | |||
There was a problem hiding this comment.
Looks like the constraint on torchvision is not needed anymore then?
This was referenced Nov 2, 2022
[ghstack-poisoned]
Merged
[ghstack-poisoned]
This was referenced Nov 4, 2022
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Nov 10, 2022
ghstack-source-id: 5a95e2c4a5d89ed1c98a6c8de3a9442ab9f4bb3d Pull Request resolved: #488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):