Address nits from previous PR stack + bump version #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Nov 10, 2022
Merged
Merged
facebook-github-bot
added
the
CLA Signed
This was referenced Nov 10, 2022
Merged
Merged
danthe3rd
pushed a commit
that referenced
this pull request
Nov 10, 2022
ghstack-source-id: 3f1beaf038a5375fa625eec3dc45f079e35afe48 Pull Request resolved: #518
fmassa
approved these changes
Nov 10, 2022
| @@ -1 +1 @@ | |||
| 0.0.14.dev | |||
| 0.0.15.dev | |||
There was a problem hiding this comment.
I would have preferred if we bumped the version in a follow-up PR
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Nov 10, 2022
ghstack-source-id: 3d0c86b5ac9297347e0a40fd20f83dfec02f74ae Pull Request resolved: #518
[ghstack-poisoned]
danthe3rd
pushed a commit
that referenced
this pull request
Nov 10, 2022
ghstack-source-id: 128d2ff4077d15fa24ceae532bfc5bd743e71b31 Pull Request resolved: #518
danthe3rd
pushed a commit
that referenced
this pull request
Nov 10, 2022
ghstack-source-id: 128d2ff4077d15fa24ceae532bfc5bd743e71b31 Pull Request resolved: #518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):