Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vertically-split plots become decoupled when one is dragged #642

Closed
v4hn opened this issue May 9, 2022 · 5 comments
Closed

vertically-split plots become decoupled when one is dragged #642

v4hn opened this issue May 9, 2022 · 5 comments

Comments

@v4hn
Copy link

v4hn commented May 9, 2022

encountered with version 3.4.3 (ROS noetic)

Steps to reproduce:

split plots vertically and add related time series:
tmp1

zoom in to one plot, the other plot aligns on the x axis:
tmp2

drag top plot with middle mouse button. X axis of bottom view should follow, but does not:
tmp3

@facontidavide
Copy link
Owner

drag top plot with middle mouse button

I don't think you can drag and drop with middle mouse. I surely can't on my computer

@v4hn
Copy link
Author

v4hn commented May 14, 2022

I'm sure I can (and I actually don't remember a time I couldn't).
Here's a screen recording: MP4/H264 / WEBM.
Notice how

  • the cursor changes to a "drag" shape when middle mouse button is pressed
  • dragging leaves the other plot not moving
  • zooming in/out realigns the two plots
  • by dragging I can actually move past the end of the data series (towards the end of the video)

It seems you/plotjuggler were just not aware of the callbacks for this?
I just made this screencast with Qt5.15.2 / qwt6.2.0 / ROS noetic / PlotJuggler commit d1544ff (almost current main), but I can definitely reproduce (at work) with a standard Ubuntu 20.04 / ROS noetic released plotjuggler.

@Bartimaeus-
Copy link
Contributor

Am able to reproduce the bug on Windows with commit e4ee67b:

Plotjuggler.Drag.-.Issue.642.mp4

facontidavide added a commit that referenced this issue Aug 5, 2022
@facontidavide
Copy link
Owner

fixed

@v4hn
Copy link
Author

v4hn commented Aug 8, 2022

Thank you so much! 💐

I am wondering whether it might feel better to move all plots around already on drag and not just on drop for "smoother" user experience, but I absolutely love the fix as is, so I will close this issue. 🦕

@v4hn v4hn closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants