Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quicker refresh/restart method for streaming ros topics #88

Closed
alsaibie opened this issue Jun 20, 2018 · 8 comments
Closed

Quicker refresh/restart method for streaming ros topics #88

alsaibie opened this issue Jun 20, 2018 · 8 comments

Comments

@alsaibie
Copy link

Hi,

When streaming rostopics, would it be possible to refresh the stream update if I restart the nodes, rather than have to stop streaming, restart and reload the topics?

Any pointers to where that can be implemented will be appreciated.
I have the latest master ver: 1.6.2

Great tool by the way, thanks.

@facontidavide
Copy link
Owner

facontidavide commented Jun 21, 2018

UPDATE:

If your roscore is not shut down, you can start, stop and restart your publishing nodes and Plotjuggler will receive the new messages without user's intervention.

On the other hand, is the roscore and the publishing nodes are shut down, then indeed PlotJuggler will require to stop/start the streamer to connect again.

If this is what you meant (confirm), I think there is a way to improve the user experience.
Something like a Pop-Up that says "Roscore is down, do you want to reconnect?"

Davide

@alsaibie
Copy link
Author

alsaibie commented Jun 21, 2018

Actually, you are right. I'll just keep roscore running in the background to keep the plots alive. Didn't consider that. That solves my concern. I was spawning master off nodes directly.

For a user experience, definitely a reconnect option when roscore went down/restarted would be useful. Instead of the stop-start-reselect topics route. Or have PlotJuggler keep a ros master running? But that may interfere with other ros use scenarios.

@facontidavide
Copy link
Owner

I don't think PlotJuggler should keep the roscore running.
I created a branch in which I started playing around with some code changes https://github.com/facontidavide/PlotJuggler/tree/issue_88

My plan is to detect that the roscore was killed using ros::master::check() and ask the user if the plugin should be stopped or else...

I think I will have something usable the next week.

facontidavide added a commit that referenced this issue Jun 24, 2018
facontidavide added a commit that referenced this issue Jun 24, 2018
@facontidavide
Copy link
Owner

Hi,

ok, I think I have done ;)

Take a look to this video to see how the new feature on the branch https://github.com/facontidavide/PlotJuggler/tree/issue_88 works.

https://vimeo.com/276755814

If it looks okay, let me know, and I will merge it with master

Cheers

@alsaibie
Copy link
Author

Hi,

Just tried it out. Works like a charm.

Thank you very much!

facontidavide added a commit that referenced this issue Jun 25, 2018
@CorentinChauvin
Copy link

Hello,

I think I found a small bug about it. Here is how I made it crash :

  • Start the ROS_Topic_Streamer, but close the dialog without selecting any topic.
  • Start the ROS_Topic_Streamer again. At this moment, the dialog doesn't even appear, and PlotJuggler crashes.

Nevertheless, thank you very much for this tool!
Corentin

@facontidavide
Copy link
Owner

Thanks for reporting, I will check this.

@facontidavide
Copy link
Owner

fixed with last commit. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants