Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid regex #1929

Merged
merged 5 commits into from
Oct 18, 2017
Merged

Remove invalid regex #1929

merged 5 commits into from
Oct 18, 2017

Conversation

miken32
Copy link
Contributor

@miken32 miken32 commented Oct 17, 2017

Resolves #1927

Before submitting your PR, please review the following checklist:

  • CHOOSE CORRECT BRANCH: if filing a bugfix/enhancement
    against 0.9.x series, choose master branch
  • CONSIDER adding a unit test if your PR resolves an issue
  • LIST ISSUES this PR resolves
  • MAKE SURE this PR doesn't break existing tests
  • KEEP PR small so it could be easily reviewed.
  • AVOID making unnecessary stylistic changes in unrelated code
  • ACCOMPANY each new failregex for filter X with sample log lines
    within fail2ban/tests/files/logs/X file

@coveralls
Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 91.956% when pulling 3f715e8 on miken32:patch-1 into c42dd69 on fail2ban:master.

@coveralls
Copy link

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 91.956% when pulling 3f715e8 on miken32:patch-1 into c42dd69 on fail2ban:master.

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #1929 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1929   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          68       68           
  Lines        7431     7431           
  Branches     1020     1020           
=======================================
  Hits         6667     6667           
  Misses        598      598           
  Partials      166      166

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42dd69...d81405a. Read the comment docs.

@sebres
Copy link
Contributor

sebres commented Oct 18, 2017

Please add a change log entry, then I'll merge it.

@miken32
Copy link
Contributor Author

miken32 commented Oct 18, 2017

Change log updated. Can this get merged onto other branches as well? Same regex is in all versions.

more detailed entry
@sebres sebres merged commit 0aeb91d into fail2ban:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants