-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix more typos #3636
base: master
Are you sure you want to change the base?
Fix more typos #3636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall .typos.toml
not be completely excluded by spelling check?
I think you mean adding it to |
I meant it introduces failure in CI now, so to pass Codespell flow it must be ignored. As for proposal to use topos, I don't think we need 2 spell checking flows in CI, so a better of both must be chosen. Is typos supported by GHA? Or would you like to use it locally only and just check-in it in repo? |
Yes it is. |
Before submitting your PR, please review the following checklist:
against certain release version, choose
0.9
,0.10
or0.11
branch,for dev-edition use
master
branchfailregex
for filterX
with sample log lineswithin
fail2ban/tests/files/logs/X
filetypos
is a superior tool. You can see it in this PR.Codespell uses regular expressions, typos understands source code.
From #3630