Add codespell: workflow, config and fix typos it finds #3630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2 ./files/fail2ban-openrc.conf ./fail2ban/tests/fail2banclienttestcase.py",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
commented
Nov 16, 2023
This was referenced Nov 18, 2023
Closed
…ning of e.g. [Uu]ser
I think it is just a filter for testing so should be safe to rename
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
df692ea
to
8ef0d3c
Compare
|
Tests pass... Merge? |
|
If you mean we really need it, then do that... |
|
ok, let's do it then in a good memory of Yarik so he never comes back with yet another spell'ing PR ;) I do not think there would even be that huge number of conflicts (I wonder if there is some service to give estimates on that). So By the power vested in me by God and man, I pronounce you 9fc754c and 8ef0d3c to be a merge! What Git has joined together, let no man put asunder. You may now rebase your PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time no commit from yours truly. I was introducing codespell to a good number of projects and eventually recalled fail2ban! I was afraid it would be non-trivial due to all the regexes etc, but it seems that codespell is damn robust and I needed to provide only a single workaround regex.
Before submitting your PR, please review the following checklist:
against certain release version, choose
0.9,0.10or0.11branch,for dev-edition use
masterbranch. In principle could be against some released branch but since renamedsubstitiontosubstitutiondecided to stick to masterCloses #2595 and Closes #3558 (supersedes)