-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell: workflow, config and fix typos it finds #3630
Conversation
=== Do not change lines below === { "chain": [], "cmd": "codespell -w -i 3 -C 2 ./files/fail2ban-openrc.conf ./fail2ban/tests/fail2banclienttestcase.py", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ning of e.g. [Uu]ser
I think it is just a filter for testing so should be safe to rename
=== Do not change lines below === { "chain": [], "cmd": "codespell -w", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [], "pwd": "." } ^^^ Do not change lines above ^^^
df692ea
to
8ef0d3c
Compare
Tests pass... Merge? |
If you mean we really need it, then do that... |
ok, let's do it then in a good memory of Yarik so he never comes back with yet another spell'ing PR ;) I do not think there would even be that huge number of conflicts (I wonder if there is some service to give estimates on that). So By the power vested in me by God and man, I pronounce you 9fc754c and 8ef0d3c to be a merge! What Git has joined together, let no man put asunder. You may now rebase your PRs. |
Long time no commit from yours truly. I was introducing codespell to a good number of projects and eventually recalled fail2ban! I was afraid it would be non-trivial due to all the regexes etc, but it seems that codespell is damn robust and I needed to provide only a single workaround regex.
Before submitting your PR, please review the following checklist:
against certain release version, choose
0.9
,0.10
or0.11
branch,for dev-edition use
master
branch. In principle could be against some released branch but since renamedsubstition
tosubstitution
decided to stick to masterCloses #2595 and Closes #3558 (supersedes)