Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation, tests, other things #2

Closed
fairingrey opened this issue Mar 12, 2018 · 0 comments
Closed

Update documentation, tests, other things #2

fairingrey opened this issue Mar 12, 2018 · 0 comments
Assignees
@fairingrey
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@fairingrey
Copy link
Owner

fairingrey commented Mar 12, 2018 •
edited
Loading

Just notes to myself, but...

#1 has introduced a few potential breaking changes

  • Pixiv::new now clones a given reqwest client.
  • PixivRequestBuilder now borrows a Pixiv instead of a Client

And also a lot of QOL things. Some errors on authorization now panic instead of trying to use an unexpected result (which is good), and certain function signatures have changed to accept more generic arguments using traits (namely favorite_works_remove and others like it).

I'll be updating this as I go since I haven't looked at absolutely everything, but I should test/review it all and push a new version soon.
@fairingrey fairingrey added enhancement New feature or request help wanted Extra attention is needed labels Mar 12, 2018
@fairingrey fairingrey self-assigned this Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fairingrey fairingrey

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fairingrey