-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Thresholder and RejectOptionClassifier #997
base: main
Are you sure you want to change the base?
Changes from 49 commits
6883b75
6747563
9d75c48
2144645
901e89b
abb5ea4
e939596
ed070d9
8aee535
bd8b44f
5b8a6bc
369aed8
0c7b856
d276880
a07f8ed
cd0ea0d
dabee57
0241e14
6079850
0a4acbd
c901231
a596905
93015c7
8d4ab22
aa6dba6
0df53f8
fb1393f
8a0e416
2ad0694
2730360
3dd8af3
bb701ab
b7838ed
d4d0f1b
62594f5
3abb15a
e21f783
39be13b
852119d
5819513
300b467
c5bca6d
abd8846
e9bda30
2c62401
0df0809
abd5271
0e7af8d
2450d0a
22a2084
f3f8c19
26020d3
6ec25e8
ed47e4f
c9353d9
2d509e9
3101ced
0960d0b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
v0.7.1 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this supposed to be part of this PR? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added this here because of this comment. Considering the recent changes about including/not including this PR in v.8 milestones, maybe it should be changed to v0.8.0.rst or removed completely? Wdyt @hildeweerts @romanlutz @adrinjalali There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file has been renamed in |
||
====== | ||
|
||
.. note:: | ||
|
||
v0.7.1 is not yet released. This page reflects changes on the current | ||
:code:`main` branch that will eventually be a part of v0.7.1. | ||
|
||
* Relaxed checks made on :code:`X` in :code:`_validate_and_reformat_input()` | ||
since that is the concern of the underlying estimator and not Fairlearn. | ||
* Add support for Python 3.9 | ||
* Added error handling in :code:`MetricFrame`. Methods :code:`group_max`, :code:`group_min`, | ||
:code:`difference` and :code:`ratio` now accept :code:`errors` as a parameter, | ||
which could either be :code:`raise` or :code:`coerce`. | ||
* Fixed a bug whereby passing a custom :code:`grid` object to a :code:`GridSearch` | ||
reduction would result in a :code:`KeyError` if the column names were not ordered | ||
integers. | ||
* :class:`~fairlearn.preprocessing.CorrelationRemover` now exposes | ||
:code:`n_features_in_` and :code:`feature_names_in_`. | ||
* Added the ACSIncome dataset and corresponding documentation. | ||
* Added :class:`~fairlearn.postprocessing.Thresholder`, including the corresponding | ||
documentation and a user guide. | ||
* Added :func:`~fairlearn.postprocessing.plot_histograms_per_group`, | ||
:func:`~fairlearn.postprocessing.plot_positive_predictions`, | ||
:func:`~fairlearn.postprocessing.plot_proba_distribution` to :code:`fairlearn.postprocessing`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be in this file and it probably should also not be part of this PR (see #1066). Instead, I would introduce the dataset briefly when it is used in the user guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I briefly introduced the dataset in the user guide, but moved it as I did because @romanlutz said
in this comment.
I agree that it does not make a lot of sense to have this dataset described in the boston housing dataset file. Shall I create a new file hospital_readmissions_dataset.rst , and create a separate PR with the purpose of providing information about this dataset similar to the way this is done in dataset_x.rst, for someone else to finish (as also suggested by roman in the comment just mentioned)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable. Seems related to #1086, or is that yet another dataset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the same dataset, so I would encourage you not to write it again :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great! I'm glad we figured that part out. Thanks @rensoostenbach for confirming!