Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device.Type Issues #224

Closed
IvanProdaiko94 opened this issue Feb 8, 2017 · 3 comments
Closed

Device.Type Issues #224

IvanProdaiko94 opened this issue Feb 8, 2017 · 3 comments
Labels

Comments

@IvanProdaiko94
Copy link

IvanProdaiko94 commented Feb 8, 2017

Hello!
It seems that in version: '0.7.12' device type detection is broken.
I mean that:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.13 Safari/537.36 { ua: 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.13 Safari/537.36'

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.19 Safari/537.36
in both UA library returned totally undefined device type, vendor and name.

@nosovk
Copy link

nosovk commented Feb 8, 2017

Just checked - confirm, looks like device type detection is broken.

@vovax87
Copy link

vovax87 commented Feb 8, 2017

I had the same bug as well - hope someone can help

@sheinbergon
Copy link

This is not a bug. Device types for desktops will always be "undefined" because unlink other devices, they're not explicitly included inside the UserAgent ( Mac is sort of an exception , and it's more of a desktop type variation then an actual device type )

See this discussion for more details - #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants