-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not use v2 alpha script in the demo page. #673
Comments
Hi @hyunbinseo, about the Naver app, can you provide us more info on why it's incorrect? along with its user-agent and what do you think the expected result should be. For a general bug report, you can use this following format: -- Describe the bug To Reproduce Expected behavior Screenshots |
Regarding the Naver app, seems like User-Agent Client Hints was the culprit.
Both v1 and v2 shows identical results in the CLI. Maybe the demo page's expression can be clarified? I thought the user-agent string was the only data being used.
According to the result however, seems like other data are used as well. Naver app is determined as Whale 1.0.0.0 as shown above. |
It used to be, before the recent development of version 2.0
Second this, needs to be rephrased to also mentions the use of client hints data. |
The mentioned description in the demo page now has been rephrased |
Currently, the demo website uses
ua-parser-js@2.0.0-alpha.2
and this causes confusion.Notable examples are
Whale@1.0.0.0
which is incorrect.I am really excited about v2, but hope it is not used until it is stable.
The text was updated successfully, but these errors were encountered: