-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add german adjectives #1023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 2115 2119 +4
Lines 227025 227439 +414
Branches 983 982 -1
==========================================
+ Hits 226280 226691 +411
- Misses 725 728 +3
Partials 20 20
|
Erstmal vielen dank für deinen Beitrag zu Faker 🙂 |
Shinigami92
approved these changes
May 30, 2022
Shinigami92
added
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
labels
May 30, 2022
import-brain
approved these changes
May 30, 2022
ST-DDT
approved these changes
May 30, 2022
xDivisionByZerox
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
m: word
Something is referring to the word module
p: 1-normal
Nothing urgent
s: accepted
Accepted feature / Confirmed bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some adjectives for de and de_AT taken from here. I didn't add them for de_CH because I think swiss german doesn't have ß and I'm unsure.
I also removed some words because of their "special" declension (for the other ones you can add an "e" and it makes sense (breite, stille), for the removed ones it wouldn't make sense). Just to make it more "machine-usable", I guess...
I also removed "christlich" (christian) and "männlich" (male) because there were no counterparts. 💩