-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(science): add more units in en locale #1386
Conversation
Should I reorder these units to be in alphabetical order? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2163 2163
Lines 241275 241303 +28
Branches 1013 1013
=======================================
+ Hits 240368 240396 +28
Misses 886 886
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to lookup these units, since I haven't used some of them before.
Not sure whether we need any more "exotic" units that this (unless there is an explicit need for a particular unit).
These units are all from the Wikipedia page on SI units (should I link that in a comment?). I added some of the SI derived units with special names/symbols so that the definitions contain all SI units. |
No description provided.