Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(science): add more units in en locale #1386

Merged
merged 3 commits into from
Sep 26, 2022
Merged

feat(science): add more units in en locale #1386

merged 3 commits into from
Sep 26, 2022

Conversation

import-brain
Copy link
Member

No description provided.

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: science Something is referring to the science module labels Sep 25, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Sep 25, 2022
@import-brain import-brain requested a review from a team September 25, 2022 17:08
@import-brain import-brain self-assigned this Sep 25, 2022
@import-brain import-brain requested a review from a team as a code owner September 25, 2022 17:08
@import-brain
Copy link
Member Author

Should I reorder these units to be in alphabetical order?

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Merging #1386 (455515d) into main (e998b58) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 455515d differs from pull request most recent head d898217. Consider uploading reports for the commit d898217 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1386   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2163     2163           
  Lines      241275   241303   +28     
  Branches     1013     1013           
=======================================
+ Hits       240368   240396   +28     
  Misses        886      886           
  Partials       21       21           
Impacted Files Coverage Δ
src/locales/en/science/unit.ts 100.00% <100.00%> (ø)

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to lookup these units, since I haven't used some of them before.
Not sure whether we need any more "exotic" units that this (unless there is an explicit need for a particular unit).

@import-brain
Copy link
Member Author

I had to lookup these units, since I haven't used some of them before.

Not sure whether we need any more "exotic" units that this (unless there is an explicit need for a particular unit).

These units are all from the Wikipedia page on SI units (should I link that in a comment?). I added some of the SI derived units with special names/symbols so that the definitions contain all SI units.

@ST-DDT ST-DDT enabled auto-merge (squash) September 26, 2022 08:08
@ST-DDT ST-DDT merged commit 8dcb584 into main Sep 26, 2022
@Shinigami92 Shinigami92 deleted the feat/add_en_units branch September 29, 2022 15:14
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: science Something is referring to the science module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants