-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(person): add Portuguese BR Language to western zodiac sign #1814
feat(person): add Portuguese BR Language to western zodiac sign #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to run pnpm run generate:locales
to update the src/locales/pt_BR/person/index.ts
file
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1814 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 2346 2347 +1
Lines 235646 235662 +16
Branches 1142 1142
==========================================
+ Hits 234798 234806 +8
- Misses 826 834 +8
Partials 22 22
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We should consider sorting these alphabetically as well (for overall easier review-ability of all locale data), although it might be detrimental for this data set in particular.
As zodiac signs have an natural order (like months) it seems more sensible to keep them in that order. |
No description provided.