Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locales): remove wrong phone number in Portugal #2029

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

MarioRodrigues10
Copy link
Contributor

This PR removes the incorrect phone number "+351 3########" from the Faker library's Portugal phone number generator.

The last major revision to the numbering plan for Portuguese phone numbers was made in 1999, with the introduction of a new numbering plan by the Portuguese National Communications Authority (ANACOM). This plan introduced new area codes and changed the format of Portuguese phone numbers to the current nine-digit format, with numbers starting with "2" used for landlines and numbers starting with "9"used for mobile phones.

@MarioRodrigues10 MarioRodrigues10 requested a review from a team as a code owner April 8, 2023 22:02
@MarioRodrigues10 MarioRodrigues10 changed the title Remove wrong phone number in Portugal fix: remove wrong phone number in Portugal Apr 8, 2023
@matthewmayer matthewmayer changed the title fix: remove wrong phone number in Portugal fix(locale): remove wrong phone number in Portugal Apr 9, 2023
@codecov
Copy link

codecov bot commented Apr 9, 2023

Codecov Report

Merging #2029 (c8df0bc) into next (79fc7c0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c8df0bc differs from pull request most recent head a4a016b. Consider uploading reports for the commit a4a016b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             next    #2029     +/-   ##
=========================================
  Coverage   99.61%   99.61%             
=========================================
  Files        2535     2563     +28     
  Lines      241584   243247   +1663     
  Branches     1282     1276      -6     
=========================================
+ Hits       240653   242310   +1657     
- Misses        904      910      +6     
  Partials       27       27             
Impacted Files Coverage Δ
src/locales/pt_PT/phone_number/formats.ts 100.00% <ø> (ø)

... and 37 files with indirect coverage changes

@matthewmayer matthewmayer changed the title fix(locale): remove wrong phone number in Portugal fix(locales): remove wrong phone number in Portugal Apr 9, 2023
@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Apr 9, 2023
@xDivisionByZerox xDivisionByZerox added m: phone Something is referring to the phone module s: accepted Accepted feature / Confirmed bug labels Apr 12, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) April 12, 2023 16:51
@ST-DDT ST-DDT merged commit 89c4cf3 into faker-js:next Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: phone Something is referring to the phone module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants