Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): update Dutch locale (nl) #2237

Merged
merged 10 commits into from
Jul 14, 2023
Merged

feat(locale): update Dutch locale (nl) #2237

merged 10 commits into from
Jul 14, 2023

Conversation

RobinvanderVliet
Copy link
Contributor

  • Add Dutch product descriptions, translated from English
  • Add missing domain suffixes
    • .frl and .amsterdam
  • Update name prefixes
    • Remove male prefix from female file
    • Add female prefix
    • Add Dr. prefix to both prefix files
  • Update product generation file
    • It used to generate grammatically incorrect product names. This is because Dutch is a grammatically gendered language. Now there are only plural nouns and nouns belonging to the common gender in the list of products.
    • Lowercased the words, since we don't write product names like that with starting capitals
    • Added more words

@RobinvanderVliet RobinvanderVliet requested a review from a team as a code owner July 3, 2023 22:39
@RobinvanderVliet RobinvanderVliet changed the title feat(locale): Update Dutch locale feat(locale): Update Dutch locale (nl) Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #2237 (069717f) into next (348c0da) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 069717f differs from pull request most recent head f2ab477. Consider uploading reports for the commit f2ab477 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2237      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2641     2640       -1     
  Lines      245760   245776      +16     
  Branches     1156     1156              
==========================================
+ Hits       244780   244784       +4     
- Misses        953      965      +12     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/nl/commerce/index.ts 100.00% <100.00%> (ø)
src/locales/nl/commerce/product_description.ts 100.00% <100.00%> (ø)
src/locales/nl/commerce/product_name.ts 100.00% <100.00%> (ø)
src/locales/nl/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/nl/person/female_prefix.ts 100.00% <100.00%> (ø)
src/locales/nl/person/male_prefix.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jul 9, 2023
@ST-DDT ST-DDT changed the title feat(locale): Update Dutch locale (nl) feat(locale): update Dutch locale (nl) Jul 14, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) July 14, 2023 19:35
@ST-DDT ST-DDT merged commit 12a511c into faker-js:next Jul 14, 2023
@RobinvanderVliet RobinvanderVliet deleted the update-nl branch July 16, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants