Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): Add bio, animal, word, music for zh_CN #2332

Merged
merged 17 commits into from
Aug 30, 2023

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Aug 21, 2023

Works

  • Add bio module for zh_CN
  • Add animal module for zh_CN
  • Add word module for zh_CN
  • Add music module for zh_CN

@CoolPlayLin CoolPlayLin requested a review from a team as a code owner August 21, 2023 10:56
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels Aug 21, 2023
ST-DDT
ST-DDT previously approved these changes Aug 21, 2023
@ST-DDT ST-DDT requested review from a team August 21, 2023 11:00
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.61%. Comparing base (16faa2a) to head (7a36ab9).
Report is 660 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2332    +/-   ##
========================================
  Coverage   99.60%   99.61%            
========================================
  Files        2735     2752    +17     
  Lines      249961   250523   +562     
  Branches     1084     1088     +4     
========================================
+ Hits       248984   249550   +566     
+ Misses        950      946     -4     
  Partials       27       27            
Files with missing lines Coverage Δ
src/locales/zh_CN/animal/bear.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/cat.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/dog.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/fish.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/horse.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/animal/type.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/index.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/music/genre.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/music/index.ts 100.00% <100.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

@CoolPlayLin
Copy link
Contributor Author

@ST-DDT It appears the first failure is due to action itself

@CoolPlayLin CoolPlayLin reopened this Aug 21, 2023
src/locales/zh_CN/person/bio_pattern.ts Outdated Show resolved Hide resolved
src/locales/zh_CN/animal/type.ts Outdated Show resolved Hide resolved
@CoolPlayLin CoolPlayLin changed the title feat(locale): Add more module for zh_CN feat(locale): Add more module for zh_CN [WIP] Aug 21, 2023
@matthewmayer
Copy link
Contributor

You can mark the pull request as Draft if it's still work in progress.

@CoolPlayLin CoolPlayLin changed the title feat(locale): Add more module for zh_CN [WIP] feat(locale): Add more module for zh_CN Aug 21, 2023
@CoolPlayLin CoolPlayLin marked this pull request as draft August 22, 2023 00:33
@ST-DDT
Copy link
Member

ST-DDT commented Aug 22, 2023

Please stay below 20 files.

This reverts commit 8bf2f5f.
@CoolPlayLin CoolPlayLin marked this pull request as ready for review August 22, 2023 09:27
@CoolPlayLin
Copy link
Contributor Author

@ST-DDT Done

@matthewmayer matthewmayer changed the title feat(locale): Add more module for zh_CN feat(locale): Add bio, animal, word, music for zh_CN Aug 23, 2023
@CoolPlayLin
Copy link
Contributor Author

@ST-DDT @import-brain

@ST-DDT
Copy link
Member

ST-DDT commented Aug 25, 2023

@ST-DDT import-brain

Please be patient. We are currently busy and dont have time to review this PR. Don't worry we haven't forgotten about it and will get to it soon.

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few words that I'm unable to check.
Maybe someone with better search or translate skills can enlighten me here.
Or provide a whole sentence/phrase containing them so that the translator can make sense from them?!

src/locales/zh_CN/word/adjective.ts Show resolved Hide resolved
src/locales/zh_CN/word/verb.ts Show resolved Hide resolved
src/locales/zh_CN/word/verb.ts Show resolved Hide resolved
@CoolPlayLin
Copy link
Contributor Author

CoolPlayLin commented Aug 28, 2023

@ST-DDT

  1. 骨碌碌:This term is often used to describe the rapid movement of the spherical object. It also could be a onomatopoeia word
  2. 披:

Wear/Wearing: "披" can mean to wear or wearing, such as wearing a robe or wearing a blanket. For example, "He is wearing a red coat."

Cover/Covering: "披" can also mean to cover or covering, like wearing a cape or letting hair down. For example, "She used a cape to cover her body."

Hang On: "披" can be used to indicate hanging something on the body, such as hanging a sword sheath or hanging a signboard. For example, "The soldier hung his sword sheath in preparation for departure."

Take On: In some idiomatic expressions, "披" can signify taking on a role or responsibility, such as "披荆斩棘" (facing difficulties bravely) or "披星戴月" (enduring hardships). For example, "He bravely faced difficulties and completed the challenging task."

Reveal/Revealing: Sometimes, "披" can also mean revealing or spreading, such as revealing information or spreading a message. For example, "He revealed an important discovery."

Spread/Spreading: In some contexts, "披" can convey the idea of spreading or disseminating, such as spreading news with a cloak or spreading a message. For example, "He spread news far and wide using a cloak."

Chew: "咀" can mean the action or process of chewing food. For example, "他正在咀东西" can be translated as "He is chewing something," indicating the action of chewing food.

Savor/Contemplate: "咀" can also represent savoring or contemplating a problem, often used in conjunction with "味" (taste). For instance, "他在咀味这个难题" can be translated as "He is contemplating this difficult problem."

Argue/Debate: In certain idiomatic expressions, "咀" can indicate arguing or debating, such as in "咀咒," which means to argue or quarrel. For example, "他们咀咒不休" can be translated as "They are constantly arguing."

Oral Communication: Sometimes, "咀" can also represent oral communication, as seen in "咀咒," where "咀" signifies oral. For instance, "他们之间的咀咒是激烈的" can be translated as "The oral exchange between them is intense."

@CoolPlayLin
Copy link
Contributor Author

I think google it directly is a good way to find meaning
image

@ST-DDT ST-DDT requested review from a team August 28, 2023 22:05
@ST-DDT ST-DDT enabled auto-merge (squash) August 30, 2023 06:10
@ST-DDT ST-DDT merged commit 8e4ea67 into faker-js:next Aug 30, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants