-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): provide strong typing for locales 2 #398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
reviewed
Feb 2, 2022
Shinigami92
reviewed
Feb 2, 2022
Shinigami92
previously approved these changes
Feb 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=========================================
Coverage 99.33% 99.34%
=========================================
Files 1920 1919 -1
Lines 174484 176291 +1807
Branches 896 898 +2
=========================================
+ Hits 173324 175133 +1809
+ Misses 1104 1102 -2
Partials 56 56
|
ST-DDT
force-pushed
the
chore/strong-types-2
branch
from
February 6, 2022 15:51
c84cdc6
to
7e60d50
Compare
Shinigami92
previously approved these changes
Feb 7, 2022
ST-DDT
force-pushed
the
chore/strong-types-2
branch
from
February 10, 2022 18:20
7e60d50
to
b11179f
Compare
Shinigami92
approved these changes
Feb 10, 2022
prisis
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
generateLocales.ts
to generate proper type definitions inlocales/.../index.ts
files.The entirety of this PR was created by the included script with the exception of 5 files where I had to manually add
as X
(weekday, month, title).@faker-js/contributors
Currently the script has the following drawbacks/limitations:
Partial<X>
to often.DEFINITIONS
variant, that only contains required properties. However, I haven't found a way to check that array for correctness at compile timeLocaleDefinition['module']
as it is already wrapped inPartial<X>
Lint-Warnings: 502 -> 205