Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): generate all locales index files with non-any types #494

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 15, 2022

Fixes #485

This PR fixes 39 warnings (273 -> 234).

@ST-DDT ST-DDT added the c: feature Request for new feature label Feb 15, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner February 15, 2022 22:08
@ST-DDT ST-DDT self-assigned this Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #494 (0321ede) into main (4c2452c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0321ede differs from pull request most recent head d481b9a. Consider uploading reports for the commit d481b9a to get more accurate results

@@           Coverage Diff            @@
##             main     #494    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1919     1919            
  Lines      176165   176333   +168     
  Branches      903      902     -1     
========================================
+ Hits       175008   175175   +167     
- Misses       1101     1102     +1     
  Partials       56       56            
Impacted Files Coverage Δ
src/locales/af_ZA/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/ar/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/ar/team/index.ts 100.00% <100.00%> (ø)
src/locales/de/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/de_AT/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/el/app/index.ts 100.00% <100.00%> (ø)
src/locales/el/business/index.ts 100.00% <100.00%> (ø)
src/locales/el/cell_phone/index.ts 100.00% <100.00%> (ø)
src/locales/el/finance/credit_card/index.ts 100.00% <100.00%> (ø)
src/locales/el/team/index.ts 100.00% <100.00%> (ø)
... and 33 more

scripts/generateLocales.ts Outdated Show resolved Hide resolved
scripts/generateLocales.ts Outdated Show resolved Hide resolved
scripts/generateLocales.ts Outdated Show resolved Hide resolved
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@Shinigami92 Shinigami92 requested a review from a team February 16, 2022 16:16
@ST-DDT ST-DDT merged commit b611ca1 into main Feb 16, 2022
@ST-DDT ST-DDT deleted the chore/strong-types-3 branch February 16, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate:locales does not update deeply nested index files
3 participants