Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fake behavior with special replacement patterns #688

Merged
merged 5 commits into from
Mar 28, 2022
Merged

fix: fake behavior with special replacement patterns #688

merged 5 commits into from
Mar 28, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 26, 2022

Fixes the issue described here: #503 (comment)

@ST-DDT ST-DDT added the c: bug Something isn't working label Mar 26, 2022
@ST-DDT ST-DDT added this to the v6.1 - First bugfixes milestone Mar 26, 2022
@ST-DDT ST-DDT self-assigned this Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022 •
edited
Loading

Codecov Report

Merging #688 (105d179) into main (8ab5eff) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 105d179 differs from pull request most recent head 7e862be. Consider uploading reports for the commit 7e862be to get more accurate results

@@           Coverage Diff            @@
##             main     #688    +/-   ##
========================================
  Coverage   99.34%   99.34%            
========================================
  Files        1924     1923     -1     
  Lines      176989   176881   -108     
  Branches      904      897     -7     
========================================
- Hits       175828   175726   -102     
+ Misses       1105     1099     -6     
  Partials       56       56
Impacted Files Coverage Δ
src/fake.ts 100.00% <100.00%> (ø)
src/index.ts 94.87% <0.00%> (-2.57%) ⬇️
src/random.ts 99.44% <0.00%> (-0.03%) ⬇️
src/helpers.ts 99.12% <0.00%> (-0.02%) ⬇️
src/faker.ts 100.00% <0.00%> (ø)
src/lorem.ts 100.00% <0.00%> (ø)
src/internal/deprecated.ts
src/system.ts 96.48% <0.00%> (+0.03%) ⬆️
src/name.ts 100.00% <0.00%> (+0.28%) ⬆️
... and 3 more

Shinigami92
Shinigami92 reviewed Mar 26, 2022
View reviewed changes
src/fake.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT marked this pull request as ready for review March 26, 2022 19:28
@ST-DDT ST-DDT requested a review from a team as a code owner March 26, 2022 19:28
xDivisionByZerox
xDivisionByZerox reviewed Mar 26, 2022
View reviewed changes
src/fake.ts Outdated Show resolved Hide resolved
@import-brain import-brain added the p: 1-normal Nothing urgent label Mar 26, 2022
@ST-DDT ST-DDT force-pushed the fix/fake-special-replacement-patterns branch from ecc5255 to 105d179 Compare March 28, 2022 08:13
@ST-DDT ST-DDT requested review from Shinigami92, xDivisionByZerox and a team March 28, 2022 08:18
@Shinigami92 Shinigami92 requested a review from a team March 28, 2022 10:30
@Shinigami92 Shinigami92 enabled auto-merge (squash) March 28, 2022 17:24
@Shinigami92 Shinigami92 merged commit 8d1aefb into main Mar 28, 2022
@Shinigami92 Shinigami92 deleted the fix/fake-special-replacement-patterns branch March 28, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox Awaiting requested review from xDivisionByZerox

Assignees

@ST-DDT ST-DDT

Labels
c: bug Something isn't working p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.1 - First bugfixes
Development

Successfully merging this pull request may close these issues.
4 participants
@ST-DDT @Shinigami92 @import-brain @xDivisionByZerox