-
-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: special characters in emails #792
feat: special characters in emails #792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like that we also add seeded based tests for this example, so we can also test the deterministic
I also thought about that and maybe we should just go with inline for now. |
Codecov Report
@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 99.35% 99.34% -0.01%
==========================================
Files 1921 1921
Lines 179085 177142 -1943
Branches 909 911 +2
==========================================
- Hits 177932 175990 -1942
+ Misses 1097 1096 -1
Partials 56 56
|
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Is there an example for this that I can follow? @Shinigami92 @ST-DDT edit: Additionally, the inclusion of special characters is based on the |
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
Resolves:
#272
Key Changes:
config: EmailConfig
option to generateemail()
andexampleEmail()
!#$%&'*+-/=?^_`{|}~
Tests:
email()
andexampleEmail()
with the added config to test special characters in emails